Skip to content

REF: de-nest Series.__setitem__ #32078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 7, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

Splitting this into a couple of steps for readability. The two main things I have in mind here are a) de-nesting, b) try to parallel the structure of __getitem__

@jbrockmendel jbrockmendel added Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code labels Feb 19, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment, rebase and ping on green.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback added this to the 1.1 milestone Mar 3, 2020
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

lgtm. can you rebase

@jbrockmendel
Copy link
Member Author

rebased+green

@simonjayhawkins simonjayhawkins merged commit ed8df2d into pandas-dev:master Mar 7, 2020
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the setitem branch March 7, 2020 15:16
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants